Re: [RFC] Asymmetric visibility

On Sun, Aug 7, 2022, at 1:59 PM, Alexandru Pătrănescu wrote: > On Fri, Aug 5, 2022 at 8:09 PM Larry Garfield <larry@garfieldtech.com> > wrote: > >> Ilija Tovilo and I are happy to present the first new RFC for PHP 8.3: >> Asymmetric Visibility. >> >> https://wiki.php.net/rfc/asymmetric-visibility >> >> Details are in the RFC, but it's largely a copy of Swift's support for the >> same. >> >> -- >> Larry Garfield >> larry@garfieldtech.com >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: https://www.php.net/unsub.php >> >> > Hi Larry, Ilija, > > Review the proposal and it looks great. > > I have a few subjects to point and maybe discuss further if you think so: > > 1. The first subject is visible even from the first phrase of the RFC that > uses both the terms "get and set operations" and "read and write > operations". > I'm wondering if you thought about using protected(write) or private(write). Not really. get/set are the terms used in every other language with such a feature, and the words are shorter. There's really no compelling reason to use a longer, less common keyword. > 3. I assume the target is both static and non-static properties. > This should be mentioned in the RFC. That's the intent, although, now that you mention it, that part hasn't been implemented yet. :-) Ilija will add that to the patch and we'll update the RFC when it's been added. Thanks for the catch. --Larry Garfield