Re: RFC json_validate() - status: Under Discussion
| From: | juan carlos morales | Date: | Fri, 26 Aug 2022 09:19:52 +0000 |
| Subject: | Re: RFC json_validate() - status: Under Discussion | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118491@lists.php.net to get a copy of this message | ||
El vie, 26 ago 2022 a las 10:28, Peter Bowyer
(<phpmailinglists@gmail.com>) escribió:
>
> Hi Juan,
>
> On Thu, 25 Aug 2022 at 17:02, juan carlos morales <dev.juan.morales@gmail..com> wrote:
>>
>> RFC: https://wiki.php.net/rfc/json_validate
>
>
> Thanks for bringing forward this RFC. I am in favour of this change, as you can't
> efficiently validate JSON in userland.
>
> Like Rowan I'm not convinced JSON_THROW_ON_ERROR belongs here. I can't think of a
> case where more than a boolean response is needed.
>
> Peter
Seems that will be a good idea to take out the usage of the flag
JSON_THROW_ON_ERROR after all. That was a nice and objective critic
and I appreciate it. Thanks! I will take it out of the implementation.
Regards
RFC: https://wiki.php.net/rfc/json_validate
Implementation: https://github.com/php/php-src/pull/9399