Re: [RFC] [Discussion] Readonly class amendments

From: Date: Fri, 20 Jan 2023 22:27:12 +0000
Subject: Re: [RFC] [Discussion] Readonly class amendments
References: 1 2 3 4 5 6 7 8 9 10 11  Groups: php.internals 
Request: Send a blank email to internals+get-119388@lists.php.net to get a copy of this message
Hey Tim, Thank you. It would probably make sense to create a separate copy of the > current version of the branch, possibly creating separate PR and then to > drop the unrelated commits from #9497 - or alternatively picking the > first 4 commits and creating a new clean PR from that. The latter is > probably preferable. There's a large number of comments in the PR itself > that do not relate to the feature-as-proposed-in-the-RFC. > OK, I've just splitted the implementation of the two functionalities, and submitted https://github.com/php/php-src/pull/10389, containing only the related changes. I'm seeing that Nicolas already spelled out the unset() part in > __clone(), but I think it would also be useful to have that within the > example code. It's more easily missed in text. Examples are cheap :-) > I've also changed the example to include the unset case as well. :) Best regards Máté

« previous php.internals (#119388) next »