Re: Deprecate ldap_connect with host and port as separate arguments

On Fri, Jan 27, 2023, at 10:28 AM, Christoph M. Becker wrote: > On 27.01.2023 at 17:06, Levi Morrison via internals wrote: > >> On Fri, Jan 27, 2023 at 8:54 AM Larry Garfield <larry@garfieldtech.com> wrote: >>> >>> On Fri, Jan 27, 2023, at 3:00 AM, Andreas Heigl wrote: >>> >>>> I think it would be a good idea to deprecate calling ldap_connect with 2 >>>> parameters host and port. >>> >>> This would require an RFC, obviously, but it seems reasonable to me. "Variable >>> meaning parameters" was always a bad idea, and cleaning them up is a good idea.> >> I disagree that this needs an RFC. The docs have long-said it's >> deprecated; adding a deprecation message _in code_ to match shouldn't >> require an RFC. > > In my opinion, a dedicated RFC would be overkill, but it could be added > to the deprecations for PHP 8.3 RFC[1] what doesn't require much effort > (feel free to add it, Andreas), and this way there would be more > visibility, and we have a vote. > > [1] <https://wiki.php.net/rfc/deprecations_php_8_3> That makes sense to me. --Larry Garfield