Re: Deprecate ldap_connect with host and port as separate arguments
| From: | Andreas Heigl | Date: | Fri, 27 Jan 2023 17:01:50 +0000 |
| Subject: | Re: Deprecate ldap_connect with host and port as separate arguments | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-119430@lists.php.net to get a copy of this message | ||
On 27.01.23 17:28, Christoph M. Becker wrote:
Attachment: [application/pgp-signature] OpenPGP digital signature OpenPGP_signature.asc
On 27.01.2023 at 17:06, Levi Morrison via internals wrote:Done. Cheers Andreas -- ,,, (o o) +---------------------------------------------------------ooO-(_)-Ooo-+ | Andreas Heigl | | mailto:andreas@heigl.org N 50°22'59.5" E 08°23'58" | | https://andreas.heigl.org | +---------------------------------------------------------------------+ | https://hei.gl/appointmentwithandreas | +---------------------------------------------------------------------+ | GPG-Key: https://hei.gl/keyandreasheiglorg | +---------------------------------------------------------------------+On Fri, Jan 27, 2023 at 8:54 AM Larry Garfield <larry@garfieldtech.com> wrote:In my opinion, a dedicated RFC would be overkill, but it could be added to the deprecations for PHP 8.3 RFC[1] what doesn't require much effort (feel free to add it, Andreas),On Fri, Jan 27, 2023, at 3:00 AM, Andreas Heigl wrote:I disagree that this needs an RFC. The docs have long-said it's deprecated; adding a deprecation message _in code_ to match shouldn't require an RFC.I think it would be a good idea to deprecate calling ldap_connect with 2 parameters host and port.This would require an RFC, obviously, but it seems reasonable to me. "Variable meaning parameters" was always a bad idea, and cleaning them up is a good idea.>
Attachment: [application/pgp-signature] OpenPGP digital signature OpenPGP_signature.asc