Re: RFC: rules for #include directives

On 2023/01/18 15:55, Max Kellermann <max+php@blarg.de> wrote: > Here's my RFC: https://wiki.php.net/rfc/include_cleanup Two weeks will be up the day after tomorrow, and there hasn't been any further discussion for more than a week, so I figure there is no further demand for discussing my RFC. I have replied to all emails here trying to explain my point, and today, I have updated the RFC to include the criticism expressed here. I have also prepared the vote doodles (four yes/no votes). Please tell me if you believe something is missing. If nobody objects, I'll announce the start of voting on February 1st. Three new relevant PRs I posted recently: - https://github.com/php/php-src/pull/10410 is a minimal PR for some include cleanup which also attempts to keep compatibility with "bad" extensions, e.g. by including errno.h from php.h - https://github.com/php/php-src/pull/10404 adds a few third-party extensions to the CI to detect accidental API breakages - https://github.com/php/php-src/pull/10472 removes existing #include comments which my work imitates, after three people expressed their unhappiness with the idea of comments on #include directives Max