Re: RFC: rules for #include directives

Hi On 1/16/23 17:25, Kamil Tekiela wrote:

Have you done any benchmarking in terms of build time? Is there any tangible difference or is it only theoretical?

From my experience contributing to another C project (HAProxy), cleaning up the the includes can have a measurable impact on build times. See this commit for example: https://github.com/haproxy/haproxy/commit/340ef2502eae2a37781e460d3590982c0e437fbd They go even as far as regularly reordering object files by build time to optimally keep multi-core machines busy to shave off the last few milliseconds: https://github.com/haproxy/haproxy/commit/d2ff5dc3ebba1163749e2d874cce5892570f540a Even for incremental build having a hypothetical 100ms decrease in build time can make the difference between "this is fast enough to wait" and "this is so slow that my mind wanders around while waiting to build". And in CI which doesn't do incremental builds we won't needlessly burn CPU time that is better spent elsewhere. Thus I'm in favor of this cleanup. Best regards Tim Düsterhus