Re: RFC: rules for #include directives
| From: | Max Kellermann | Date: | Fri, 20 Jan 2023 15:49:04 +0000 |
| Subject: | Re: RFC: rules for #include directives | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-119377@lists.php.net to get a copy of this message | ||
On 2023/01/20 16:00, "Christoph M. Becker" <cmbecker69@gmx.de> wrote:
> I'm afraid the worst that can actually happen is that this breaks a lot
> of PHP extensions, SAPIs, etc.
True, I meant out-of-tree code, too.
I will add some extra care to ensure compatibility even with "bad"
extensions, by re-adding removed #include lines to php[_compat].h, as
suggested by Jakub.
I agree that any breakages of out-of-tree code could (or should) be
regarded a regression that needs to be fixed, no matter how bad that
code is. I'm ready to take responsibility for eventual breakages and
do my best to submit fixes quickly.
> We do not know how many there are, and we cannot even check all PECL
> extensions for practical reasons.
It would be helpful to add a few selected extensions to the CI, so
unintended API regressions are detected as early as possible.
> So we need to be careful here.
Understood, I will!
Max