Re: RFC: rules for #include directives
| From: | Max Kellermann | Date: | Fri, 20 Jan 2023 11:00:24 +0000 |
| Subject: | Re: RFC: rules for #include directives | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-119365@lists.php.net to get a copy of this message | ||
On 2023/01/20 11:51, Michael Voříšek - ČVUT FJFI <vorismi3@fjfi.cvut.cz> wrote:
> I would highly appreciate if this could be done automatically, ie.
> generate "the correct" includes and assert them by
>
> https://github.com/php/php-src/blob/php-8.2.1/.github/actions/verify-generated-files/action.yml
> CI. If you can generate the comments too, they can be asserted by CI
> reliably then as well.
Agree, it would be a good idea to integrate iwyu into the CI.
(Of course, only if we agree that cleaning up those includes is a
desired goal for the PHP project.)
Max