Re: Patch: Rasmus statcallpatch with configure option

On Tue, 14 Sep 2004, Zeev Suraski wrote: > I don't disagree that it can be useful. But such a feature should not come > bundled as an option in PHP. The Right(tm) solution here is to provide the > realpath cache, which will speed performance up without breaking > compatibility, and hopefully we'll have that one real soon now. We can > maybe look into backporting it to PHP 4 as an optional feature (just to > make sure we don't break apps in case it's buggy). The realpath cache is not nearly what Rasmus patch does. Besides that, the patch seems to be rock solid (we've customers running it in production now). > Adding this patch as an option goes against everything that we've been > trying to do in the last few years. This useful patch should be made > available so that those who really need it can find it, but it should come > up with a huge disclaimer, and it should not be trivial for users to enable > it in the form of --enable-foo. I see the fact that people have to invest > some work in using it as a good thing, since if a lot of people start using > it, it can become a very big headache very quickly. --enable-foo=40digit-prime-of-your-choice? For people who use it, they would use this professionally. They are most often not even *allowed* to patch their PHP nor do they want to spend time on applying this patch each time. Also, it's not an inherently bad patch either. You just need to make sure that 1) you don't use symlinks and 2) always include a file with the same file path. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org