Re: Patch: Rasmus statcallpatch with configure option

Jan Schneider wrote:

Zitat von Derick Rethans <derick@php.net>:

On Tue, 14 Sep 2004, Andi Gutmans wrote:

a) I will try and send internals@ an updated version of the realpath() cache in the next few days. This should give a lot of bang for the buck because realpath() is probably the suckiest system call in the startup. b) Maybe Wez & Sara can take one more look to double check if there aren't any checks they can possibly save without impairing functionality. c) Create a new version of your patch based on (a) & (b) and make sure we find an accessible place for it with the disclaimer.

A good accessible place would be our distribution. It's annoying to have to maintain a patch outside the main tree. There is also no reason why people would just enable this feature by default if they have no clue what they are doing, we can add big nice disclaimers around it. I can see nothing wrong with it, I also don't think this is a nasty hack or a crappy patch. I do not seek to have this patch into PHP 5, you can do your realcache magic there if you want.

Why not keeping that patch (and others that might be worth it as well) in the php-src module, but really as a patch, not applied to the default distro? This way it's available at a single point, everyone having a tarball can apply it, and it still won't be available with a simple config option. Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting/ If kept like this it has to be updated, which almost no different from the case being

on zend.com . To make it harder for someone to shoot himself then let it in without configure option but a #define somewhere. If someone wants to compile it with this support (s)he has to change the value of the #define. Andrey