Re: patch-fd-lexer5

At 15:00 13.05.2003 -0700, Rasmus Lerdorf wrote:

On Wed, 14 May 2003, Jani Taskinen wrote:

today I discovered that I had overlooked a zend_fopen call in zend_execute.c which caused PHP/Solaris to still fail in some cases. The new patch modifies the specific section of code (right at the beginning of the patch): http://schumann.cx/patch-fd-lexer5 The current load test will run over night. If it is successful, I'll propose to merge this into PHP_4_3.

    Just commit. PHP_4_3 can't get any more broken than what it is now.

It seems pretty stable to me. What exactly are you referring to, or is this just your sarcastic way of disagreeing with this going into 4.3 at all? 4.3 is currently almost unusable on Solaris, which is a big bug. As far as I am concerned, Sascha is fixing a rather serious bug. Granted, it is a big change, and if the 4.3 release manager says that this shouldn't go into 4.3.2 because we are too close to the 4.3.2 release, then that is perfectly valid. Let's aim this at 4.3.3 then. But we clearly need to address this problem in the 4.3 codebase at some point. We can't just tell Solaris users that they are screwed and that they should go and try to hack sfio into PHP themselves. -Rasmus

I agree, it seems stable to me, too. The only thing to do is to check extensions for use of fopen/fdopen. Often you find similar lines to this in extensions (just search the code):

        fh.handle.fp = VCWD_FOPEN(Z_STRVAL_PP(filename), "r");

this should be changed, too. I am rewriting for example browscap.c to use streams without knowing if they use fp or fd when reading ini file.