Re: patch-fd-lexer5
| From: | Rasmus Lerdorf | Date: | Tue, 13 May 2003 22:19:08 +0000 |
| Subject: | Re: patch-fd-lexer5 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-1497@lists.php.net to get a copy of this message | ||
On Wed, 14 May 2003, Uwe Schindler wrote:
> I agree, it seems stable to me, too. The only thing to do is to check
> extensions for use of fopen/fdopen.
> Often you find similar lines to this in extensions (just search the code):
> fh.handle.fp = VCWD_FOPEN(Z_STRVAL_PP(filename), "r");
> this should be changed, too.
> I am rewriting for example browscap.c to use streams without knowing if
> they use fp or fd when reading ini file.
Sure, but this is orthogonal to the patch itself. Getting rid of stdio in
other places is a good idea, but it doesn't absolutely have to be done.
Getting rid of it in the core gets us most of the way there. Chances are
the few other places in external bits won't overflow the fp limit.
-Rasmus