Re: patch-fd-lexer5

On Tue, 13 May 2003, Rasmus Lerdorf wrote: >On Wed, 14 May 2003, Jani Taskinen wrote: >> > today I discovered that I had overlooked a zend_fopen call in >> > zend_execute.c which caused PHP/Solaris to still fail in some >> > cases. >> > >> > The new patch modifies the specific section of code (right at >> > the beginning of the patch): >> > >> > http://schumann.cx/patch-fd-lexer5 >> > >> > The current load test will run over night. If it is >> > successful, I'll propose to merge this into PHP_4_3. >> >> >> Just commit. PHP_4_3 can't get any more broken than what it is now. > >It seems pretty stable to me. What exactly are you referring to, or is >this just your sarcastic way of disagreeing with this going into 4.3 at >all? Heh, I meant the specific problem this solves can't get any worse. >4.3 is currently almost unusable on Solaris, which is a big bug. As far >as I am concerned, Sascha is fixing a rather serious bug. Granted, it is >a big change, and if the 4.3 release manager says that this shouldn't go >into 4.3.2 because we are too close to the 4.3.2 release, then that is And I already promised that this fix will be in 4.3.2. :) I will roll RC3 once this patch is in. There's also the fix for the array stuff Ilia just committed that needs some testing too. --Jani