Re: Bundling libxml2 default?

On Mon, May 19, 2003 at 12:24:21AM +0900, Moriyoshi Koizumi wrote: > Adam Dickmeiss <adam@indexdata.dk> wrote: > > > > I made a patch to accomplish Adam's suggestion: > > > http://www.voltex.jp/patches/bundle-libxml.patch.diff > > I've applied your patch. Things didn't work quite as I expected. > > > > First of all, default is that Expat is enabled and bundled. libxml > > is off by default. This is due to ",no" and ",bundled" in > > PHP_ARG_BUNDLE in bundle/libxml/config.m4 and bunle/expat/config.m4 > > respectively. I thought we wanted libxml enabled and Expat disabled. > > So I then used > > --with-libxml --without-expat > > which I assumed would choose my already installed libxml. That still > > used the bundled version of libxml. > > forgot to mention the meaning of options: > > --with-libxml=auto => detecting the location of libxml automatically > --with-libxml=PFX => using the libxml installed in the specified prefix > --with-libxml=bundled => using the bundled libxml > --with-libxml => using the bundled libxml > default: disabled (in order to avoid confusion) > > --with-expat=bundled => using the bundled expat > --with-expat=PFX => using the expat installed in the specified prefix > --with-expat => looking for libexpat in either /usr or /usr/local > default: enabled (--with-expat=bundled) > > Moriyoshi Hi, I took Moriyoshi's patch. Twisted it a bit so that libxml2 is default enabled. Expat is disabled. --with-libxml uses system wide if found. Otherwise bundled version. --with-libxml=bundled use bundled version. --with-libxml[=dir] use version in dir. The Expat config.m4 is barely touched. It does not yet use system wide by default. Also modified ext/domxml/config.m4 a bit. Uses PHP_EVAL_INCLINE for PHP_LIBXML_CFLAGS . You can get the patch here: http://dickmeiss.net/files/bundle-libxml.patch2 (the diff is against PHP CVS, not against PHP CVS + Moriyoshi's patch) -- Adam -- Adam Dickmeiss mailto:adam@indexdata.dk http://www.indexdata.dk Index Data T: +45 33410100 Mob.: 212 212 66