Re: Re: php-src /ext/dom attr.c cdatasection.c characterdata.c comment.c document.c documentfragment.c dom_iterators.c domexception.c
domimplementation.c element.c entityreference.c namednodemap.c node.c nodelist.c php_dom.c processinginstruction.c text.c xpat
| From: | Andrei Zmievski | Date: | Fri, 12 Aug 2005 16:28:27 +0000 |
| Subject: | Re: Re: php-src /ext/dom attr.c cdatasection.c characterdata.c comment.c document.c documentfragment.c dom_iterators.c domexception.c domimplementation.c element.c entityreference.c namednodemap.c node.c nodelist.c php_dom.c processinginstruction.c text.c xpat |
||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-17877@lists.php.net to get a copy of this message | ||
On Aug 12, 2005, at 8:18 AM, <cshmoove@bellsouth.net> wrote:
Dmitry, i'm glad its fixed, but i was hoping it wouldnt get fixed this way ;-) maybe a lower impact way would have been to move the use of U_CLASS_ENTRY into zend_parse_parameters, zend_throw_exception, instanceof_function etc ?Yes, this is pretty high impact as far as code changes are concerned. Since one should not attempt to access a class entry without U_CLASS_ENTRY() macro, should it even be optional? -Andrei