Re: Re: php-src /ext/dom attr.c cdatasection.c characterdata.c comment.c document.c documentfragment.c dom_iterators.c domexception.c
domimplementation.c element.c entityreference.c namednodemap.c node.c nodelist.c php_dom.c processinginstruction
| From: | l0t3k | Date: | Fri, 12 Aug 2005 22:18:59 +0000 |
| Subject: | Re: Re: php-src /ext/dom attr.c cdatasection.c characterdata.c comment.c document.c documentfragment.c dom_iterators.c domexception.c domimplementation.c element.c entityreference.c namednodemap.c node.c nodelist.c php_dom.c processinginstruction |
||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-17926@lists.php.net to get a copy of this message | ||
"Andrei Zmievski" <andrei@gravitonic.com> wrote in message
news:847b3e28b1df40c86b05d83bd2d319ed@gravitonic.com...
> Yes, this is pretty high impact as far as code changes are concerned.
> Since one should not attempt to access a class entry without
> U_CLASS_ENTRY() macro, should it even be optional?
my uneasiness with this is that if the macro is mandatory, it (to me)
implies, from a usability point of view, that
that zend_parse_parameters, instanceof_functions etc are now "broken".
z_p_p, for example, was a god-send, because it took care of all the
lifting, without reminding me of implementation details. now everytime i use
it with objects, im forced to think of whether or not i'm in unicode mode,
when i neither knew or cared about such things when the class_entry was
created.
i really think the macro should be moved to the appropriate functions.
clayton