Re: Re: php-src /ext/dom attr.c cdatasection.c characterdata.c comment.c document.c documentfragment.c dom_iterators.c domexception.c
domimplementation.c element.c entityreference.c namednodemap.c node.c nodelist.c php_dom.c processinginstruction

On Aug 12, 2005, at 3:18 PM, l0t3k wrote:

my uneasiness with this is that if the macro is mandatory, it (to me) implies, from a usability point of view, that that zend_parse_parameters, instanceof_functions etc are now "broken". z_p_p, for example, was a god-send, because it took care of all the lifting, without reminding me of implementation details. now everytime i use it with objects, im forced to think of whether or not i'm in unicode mode, when i neither knew or cared about such things when the class_entry was created. i really think the macro should be moved to the appropriate functions.

It's not just these functions - class entries are used in plenty of other places and having to use a special macro for all of those instances kind of sucks. At the very least, it's a big API BC breakage. -Andrei