Re: cvs: php-src /ext/standard string.c /ext/standard/tests/strings bug22224.phpt
| From: | Andrei Zmievski | Date: | Wed, 17 Aug 2005 16:40:53 +0000 |
| Subject: | Re: cvs: php-src /ext/standard string.c /ext/standard/tests/strings bug22224.phpt | ||
| References: | 1 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-18195@lists.php.net to get a copy of this message | ||
Dmitriy,
Where did EMPTY_STR come from? It seems to be used in non-Unicode context also:
Zend/zend_API.c:
zend_error(error_type, "Method %s%s%s() cannot be a NULL function", scope ? scope->name : EMPTY_STR, scope ? "::" : "", ptr->fname);
Besides, it generates a compile warning. Should we have this instead?
#define U_EMPTY_STR ((UChar*)"\0\0")
-Andrei
On Aug 17, 2005, at 12:59 AM, Dmitry Stogov wrote:
- ZVAL_UNICODEL(delim, USTR_MAKE(""), sizeof("")-1, 0); + ZVAL_UNICODEL(delim, EMPTY_STR, sizeof("")-1, 0);