RE: [PHP-CVS] cvs: php-src /ext/standard string.c /ext/standard/tests/strings bug22224.phpt
| From: | Dmitry Stogov | Date: | Wed, 17 Aug 2005 17:27:46 +0000 |
| Subject: | RE: [PHP-CVS] cvs: php-src /ext/standard string.c /ext/standard/tests/strings bug22224.phpt | ||
| References: | 1 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-18197@lists.php.net to get a copy of this message | ||
Hi,
> Dmitriy,
>
> Where did EMPTY_STR come from?
It was defined by me.
> It seems to be used in non-Unicode
> context also:
>
> Zend/zend_API.c:
> zend_error(error_type, "Method %s%s%s() cannot be a NULL
> function",
> scope ? scope->name : EMPTY_STR, scope ? "::" : "", ptr->fname);
This place doesn't need EMPTY_STR. ("" is enough)
> Besides, it generates a compile warning. Should we have this instead?
>
> #define U_EMPTY_STR ((UChar*)"\0\0")
I agree, but probably we will get warnings in other places.
Dmitry
> -Andrei
>
> On Aug 17, 2005, at 12:59 AM, Dmitry Stogov wrote:
>
> > - ZVAL_UNICODEL(delim,
> USTR_MAKE(""), sizeof("")-1, 0);
> > + ZVAL_UNICODEL(delim, EMPTY_STR,
> sizeof("")-1, 0);
>
>