Re: tsrm_shutdown() and the CLI SAPI

Without looking to deeply into this reincarnation my guess would be that for CLI, Zeev's approach makes good sense. Andi At 08:04 PM 5/27/2006, Steph Fox wrote:

Thanks Xuefer... This bug's been extant for a long time, and I only found out why when I spent two days/nights trying to track down its history and mechanics. It's a pig. - Steph ----- Original Message ----- From: "Xuefer" <xuefer@gmail.com> To: "Steph Fox" <steph@zend.com> Cc: "internals" <internals@lists.php.net> Sent: Sunday, May 28, 2006 4:58 AM Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

i can confirm this on other extension. something like this grep free_id */*.c -B1 -A3 mbstring/mbstring.c-#ifdef ZTS

mbstring/mbstring.c:    ts_free_id(mbstring_globals_id);

mbstring/mbstring.c-#else

mbstring/mbstring.c-    _php_mb_globals_dtor(&mbstring_globals TSRMLS_CC);

mbstring/mbstring.c-#endif have no problem with it while some modules like $ grep 'ndef ZTS' */*.c -A2 apc/php_apc.c:#ifndef ZTS

apc/php_apc.c-        php_apc_shutdown_globals(&apc_globals);

apc/php_apc.c-#endif - eaccelerator/eaccelerator.c:#ifndef ZTS eaccelerator/eaccelerator.c- eaccelerator_globals_dtor(&eaccelerator_globals TSRMLS_CC); eaccelerator/eaccelerator.c-#endif when compiled as shared module, will crash eaccelerator(mmcache) workaround it by disabling the dtor. /*??? FIXME ZEND_INIT_MODULE_GLOBALS(eaccelerator, eaccelerator_init_globals, eaccelerator_globals_dtor); */ ZEND_INIT_MODULE_GLOBALS(eaccelerator, eaccelerator_init_globals, NULL);

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php