Re: tsrm_shutdown() and the CLI SAPI

Did you see my patch? ----- Original Message ----- From: "Dmitry Stogov" <dmitry@zend.com> To: "'Steph Fox'" <steph@zend.com>; "'Xuefer'" <xuefer@gmail.com>; "'Andi Gutmans'" <andi@zend.com> Cc: "'internals'" <internals@lists.php.net>; "'Antony Dovgal'" <antony@zend.com> Sent: Friday, June 02, 2006 8:11 AM Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

I am working in this way, but this willnot help you with php-gtk for php-5.1 Dmitry.

-----Original Message----- From: Steph Fox [mailto:steph@zend.com] Sent: Thursday, June 01, 2006 9:19 PM To: Dmitry Stogov; 'Xuefer'; 'Andi Gutmans' Cc: 'internals'; 'Antony Dovgal' Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI I already wasted several hours on that :) I agree that making it work from inside zend_shutdown would be the smart approach, but don't see why you think it will need any extension mods (although it might need minor TSRM mods to flag 'done' table entries in all cases). The sane thing would be to call ts_free_id() from the module_destructor function somehow... but.... the globals_id field isn't populated in the zend_module_entry struct currently, and my attempts to populate it haven't been successful to date. ----- Original Message ----- From: "Dmitry Stogov" <dmitry@zend.com> To: "'Steph Fox'" <steph@zend.com>; "'Xuefer'" <xuefer@gmail.com>; "'Andi Gutmans'" <andi@zend.com> Cc: "'internals'" <internals@lists.php.net>; "'Antony Dovgal'" <antony@zend.com> Sent: Thursday, June 01, 2006 8:34 AM Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI I agree. I'll try to make it work from inside zend_shudown() but probably it will requre modification of EVERY extension that uses module_globals in any case. Thanks. Dmitry.

-----Original Message----- From: Steph Fox [mailto:steph@zend.com] Sent: Thursday, June 01, 2006 8:48 AM To: Dmitry Stogov; 'Xuefer'; Andi Gutmans Cc: 'internals'; Antony Dovgal Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

I'm a bit behind so sorry if this has been answered

already. I don't

think ts_free_id() is a workaround but it's actually correct.

ts_free_id() would be a correct workaround if it came from zend_shutdown(). How's it right to suddenly force EVERY extension author to add it to their code individually? We

should free the resources of the extension during MSHUTDOWN

and that's

the way to do it in ZTS. Good chance that the crash is actually

a bug which

needs fixing although there could also be a bug lurking. Andi

__________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com

__________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com