Re: [PATCH] Automatic module globals management

DS>>The attached patch (for PHP_5_2) implements automatic management of module DS>>globals. DS>>The problem that module globals must be unregistered before extension DS>>unloading, because "globls_dtor" function is unloaded together with DS>>extension and cannot be called. I think the patch itself looks fine, and makes globals management cleaner. However, I'm not sure it would be for 5.2 for reasons cited by Steph - probably not a lot of extension would be reworked specifically for 5.2 (correct me if I'm wrong here) but for 6.0 probably most of them would need some massaging here and there, so putting it in 6.0 is quite OK, but putting it into 5.2 probably would not be used too much outside the engine modules - for which it doesn't matter much since we can fix them with old API as far as I see. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115