RE: [PHP-DEV] Re: [PATCH] Automatic module globals management
| From: | Dmitry Stogov | Date: | Tue, 13 Jun 2006 13:22:19 +0000 |
| Subject: | RE: [PHP-DEV] Re: [PATCH] Automatic module globals management | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24109@lists.php.net to get a copy of this message | ||
Steph,
I don't understand your patch.
(It doesn't compile without my patch and doesn't need with it).
Why you don't just call ts_free_id(*module->globals_id_ptr) and do so large
extra work?
Why you free globals for external extensions and not for internals?
Thanks. Dmitry.
> -----Original Message-----
> From: Steph Fox [mailto:steph@zend.com]
> Sent: Sunday, June 11, 2006 12:49 PM
> To: Stanislav Malyshev
> Cc: Dmitry Stogov; internals@lists.php.net
> Subject: Re: [PHP-DEV] Re: [PATCH] Automatic module globals management
>
>
> Hi Stas
>
>
> > SF>>resource id, and it would need to be a ZTS build.
> Whatever way you
> > look at
> > SF>>it, that's a screwed up configuration.
> >
> > So we would blame the user for our broken code. Do you think it's a
> > good idea.
>
> No I don't, so I wrote something completely different. Is the
> attached a
> better solution?
> Again, it's intended to work _alongside_ Dmitry's, not
> replace it. It checks
> for globals_id_ptr, you need to change that to globals_id if
> you're trying
> it against current 5_2.
>
> - Steph
>
> >
> > --
> > Stanislav Malyshev, Zend Products Engineer
> > stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115
> >
>