Re: Re: [PATCH] Automatic module globals management

Dmitry, hi, It only doesn't compile without your patch because you changed the module structure in your patch :) It compiles fine if you check for something that exists in 5_2 already instead of checking for something that will exist next week. It needs 'with it' to prevent crashes that win32 extensions will continue to have until they upgrade to use your new API. Internal modules don't cause those crashes, only external modules do. Everything gets freed in the end anyway, it's just a matter of timing for the external ones. - Steph ----- Original Message ----- From: "Dmitry Stogov" <dmitry@zend.com> To: "'Steph Fox'" <steph@zend.com>; "'Stanislav Malyshev'" <stas@zend.com> Cc: <internals@lists.php.net> Sent: Tuesday, June 13, 2006 3:22 PM Subject: RE: [PHP-DEV] Re: [PATCH] Automatic module globals management

Steph, I don't understand your patch. (It doesn't compile without my patch and doesn't need with it). Why you don't just call ts_free_id(*module->globals_id_ptr) and do so large extra work? Why you free globals for external extensions and not for internals? Thanks. Dmitry.

-----Original Message----- From: Steph Fox [mailto:steph@zend.com] Sent: Sunday, June 11, 2006 12:49 PM To: Stanislav Malyshev Cc: Dmitry Stogov; internals@lists.php.net Subject: Re: [PHP-DEV] Re: [PATCH] Automatic module globals management Hi Stas

SF>>resource id, and it would need to be a ZTS build.

Whatever way you

look at SF>>it, that's a screwed up configuration. So we would blame the user for our broken code. Do you think it's a good idea.

No I don't, so I wrote something completely different. Is the attached a better solution? Again, it's intended to work _alongside_ Dmitry's, not replace it. It checks for globals_id_ptr, you need to change that to globals_id if you're trying it against current 5_2. - Steph

-- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115

__________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com