Re: Re: cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

Marcus Boerger wrote:

Hello Stefan, Sunday, July 23, 2006, 3:39:35 AM, you wrote:

If you'd be grown up yourself, you would just commit to HEAD instead of spending time on meaningless insults.

Commiting to HEAD is not possible. How often do I have to tell that. Because of the unicode changes the patch has to be majorly rewritten. Additionally it is simply impossible to commit to HEAD and test against it, because the fileupload code in CVS HEAD is broken because of all the unicode changes.

Nonetheless you are inventing a new feature here. One that has been asked for and for which patches have often been offered in the past. The general idea was to add the feature once we have a working patch, so in this sense it was ok to add the patch. However i am not sure you didn't try to sneak the stuff in as Pierre would have called it, since i doubt it was actively on any todo or any agreement for 5.2.

It is before the first RC, although very close to it, so as far as I am concerned it is up to the release manager to decide on this one. Looking at the code it looks ok to me. -Rasmus