Re: Re: cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h
| From: | Ilia Alshanetsky | Date: | Mon, 24 Jul 2006 13:32:48 +0000 |
| Subject: | Re: Re: cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24927@lists.php.net to get a copy of this message | ||
On 24-Jul-06, at 4:38 AM, Stefan Esser wrote:
Ilia Alshanetsky schrieb:True, but I think the assumption was that this was intended for PHP6 rather then PHP 5.2 hence the confusion. Ilia AlshanetskyI reviewed the code and as far as I can tell it works fine. Certainly, some sort of an earlier courtesy notice to the RM would've been nice, but as Rasmus said this is till before RC1, so do I don't see a problem with the patch's inclusion. That said, if it becomes apparent that the code does not work properly before we go for RC2, I will revert the patch and we can consider it for the next 5.X release.At the 3.July. I sent more or less exactly THIS patch to the internals list, announcing that I will commit it into PHP_5_2 in the next days. Noone spoke up against it. Ilia even replied: Looks fine to me.