Re: Re: cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h
| From: | Stefan Esser | Date: | Mon, 24 Jul 2006 08:38:50 +0000 |
| Subject: | Re: Re: cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24924@lists.php.net to get a copy of this message | ||
Ilia Alshanetsky schrieb:
> I reviewed the code and as far as I can tell it works fine. Certainly,
> some sort of an earlier courtesy notice to the RM would've been nice,
> but as Rasmus said this is till before RC1, so do I don't see a
> problem with the patch's inclusion. That said, if it becomes apparent
> that the code does not work properly before we go for RC2, I will
> revert the patch and we can consider it for the next 5.X release.
At the 3.July. I sent more or less exactly THIS patch to the internals
list, announcing that I will commit it into PHP_5_2 in the next days.
Noone spoke up against it. Ilia even replied: Looks fine to me.
So guys please don't say that I sneaked something in, or that my notice
was not early enough. The commit was announced about 20 days before it
happend. I guess that was a long enough notice.
Stefan