Re: Objectified Request Parameters
| From: | Pierre | Date: | Mon, 29 Jan 2007 13:58:21 +0000 |
| Subject: | Re: Objectified Request Parameters | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-27706@lists.php.net to get a copy of this message | ||
Hi,
strong -1.
On 1/29/07, Dmitry Stogov <dmitry@zend.com> wrote:
+1 I like this solution and I don't think that BC break is important for many applications.I disagree: $d = $_GET; $f->do($d); class foo { function do(array $d) {} or function do($d) { if (!is_array())... } } or a simple review: http://www.google.com/codesearch?hl=en&lr=&q=lang%3Aphp+is_array%5C%28%5C%24_POST%5C%29&btnG=Search
Not a lot of them use is_array($GET), and I believe no one use is_object($_GET). $get = $_GET may be a problem, but moving from PHP5 to PHP6 won't easy in any case.Yes, but breaking that is a pointless change. I see no benefit to trick the GPC array like that only to solve something that will require more work anyway. Having normal arrays, a couple of functions and, if we agree, a new OO API is easier for everyone, user included. And the solutions can work together, example: http_input_econding(filter_input(INPUT_GET, 'encoding', FILTER_SANITIZE_STRING); $myvar = $_GET['myval']; $someint = $cgi->getInteger('myinteger'); They can all work the same way, transparently and does not break anything. Yes, php6 move will require changes but I would rather prefer not to break GPC arrays. --Pierre