Re: [PATCH] Major optimization for heredocs/interpolated strings
| From: | Andrei Zmievski | Date: | Thu, 26 Apr 2007 15:53:28 +0000 |
| Subject: | Re: [PATCH] Major optimization for heredocs/interpolated strings | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29052@lists.php.net to get a copy of this message | ||
On Apr 26, 2007, at 2:30 AM, Matt Wilmas wrote:
BTW, regarding HEAD, for you, Andrei, or anyone, I think I noticed a bug, unrelated to my changes: CG(literal_type) isn't set for backticks in the parser, so it winds up being whatever was last set. I would've changed it, but didn't know if it's supposed to always be IS_STRING or dependent on UG(unicode).Thanks, I remember leaving that out since we didn't have filesystem encoding support yet, but it's definitely should be there now. Fixed. Also, I'm for committing your patch to HEAD and 5.3. -Andrei