RE: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings

Sure makes even more sense. > -----Original Message----- > From: Marcus Boerger [mailto:helly@php.net] > Sent: Thursday, April 26, 2007 10:24 AM > To: Andi Gutmans > Cc: Andrei Zmievski; Matt Wilmas; internals@lists.php.net > Subject: Re: [PHP-DEV] [PATCH] Major optimization for > heredocs/interpolated strings > > Hello Andi, > > how about you guys review/test it and then commit it if you > agree to it? > > best regards > marcus > > Thursday, April 26, 2007, 7:18:46 PM, you wrote: > > > Before you commit it, give us a few more days to review it. > We need to > > be careful before commiting major changes to the scanner. > If it checks > > out I'm definitely fine with commiting. > > > Andi > > >> -----Original Message----- > >> From: Andrei Zmievski [mailto:andrei@gravitonic.com] > >> Sent: Thursday, April 26, 2007 8:53 AM > >> To: Matt Wilmas > >> Cc: internals@lists.php.net; Marcus Boerger > >> Subject: Re: [PHP-DEV] [PATCH] Major optimization for > >> heredocs/interpolated strings > >> > >> On Apr 26, 2007, at 2:30 AM, Matt Wilmas wrote: > >> > >> > BTW, regarding HEAD, for you, Andrei, or anyone, I think I > >> noticed a > >> > bug, unrelated to my changes: CG(literal_type) isn't set > >> for backticks > >> > in the parser, so it winds up being whatever was last set. > >> I would've > >> > changed it, but didn't know if it's supposed to always be > >> IS_STRING or > >> > dependent on UG(unicode). > >> > >> Thanks, I remember leaving that out since we didn't have > filesystem > >> encoding support yet, but it's definitely should be there > now. Fixed. > >> > >> Also, I'm for committing your patch to HEAD and 5.3. > >> > >> -Andrei > >> > >> -- > >> PHP Internals - PHP Runtime Development Mailing List To > unsubscribe, > >> visit: http://www.php.net/unsub.php > >> > >> > > > > > Best regards, > Marcus > >