RE: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings
| From: | Dmitry Stogov | Date: | Fri, 18 May 2007 07:52:22 +0000 |
| Subject: | RE: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29509@lists.php.net to get a copy of this message | ||
At least 2% speedup on attached script.
Thanks. Dmitry.
> -----Original Message-----
> From: Stanislav Malyshev [mailto:stas@zend.com]
> Sent: Thursday, May 17, 2007 8:52 PM
> To: Dmitry Stogov
> Cc: 'Matt Wilmas'; internals@lists.php.net; 'Andi Gutmans'
> Subject: Re: [PHP-DEV] [PATCH] Major optimization for
> heredocs/interpolated strings
>
>
> > The patch mainly improves not the parser, but generated code. It
> > builds near optimal ZEND_ADD_STRING, ZEND_ADD_VAR sequence
> for quoted
> > strings and heredoc.
>
> OK, I understand that, the question is can we see any
> difference? We are
> doing quite major overhaul of the parser, so there should be a reason
> for it - like the code gets to be that and that faster, etc.
> Is there a
> way to see it?
>
> > You can see a small difference even on Zend/bench.php.
>
> Actually I don't :) Not beyond the margin of error at least. I'm not
> very surprised since bench.php doesn't do much with
> interpolated strings
> as I see - but I would like to verify that this patch is
> really a "major
> optimization" ;)
>
> --
> Stanislav Malyshev, Zend Products Engineer
> stas@zend.com http://www.zend.com/
>
Attachment: [application/x-httpd-php] bench2.php
Attachment: [application/x-httpd-php] bench2.php