Re: Deprecating php_dirname() in 5_3, removing in HEAD
| From: | Pierre Joye | Date: | Thu, 06 Mar 2008 00:36:18 +0000 |
| Subject: | Re: Deprecating php_dirname() in 5_3, removing in HEAD | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-35990@lists.php.net to get a copy of this message | ||
On Thu, Mar 6, 2008 at 1:32 AM, Lars Strojny <lars@strojny.net> wrote:
> Hi Pierre,
>
> Am Donnerstag, den 06.03.2008, 01:30 +0100 schrieb Pierre Joye:
> [...]
>
> > I'm talking about extension developers. We will all have to add yet
> > another #ifdef for this function, in the implementation or to define
> > php_dirname to keep the implementation clean(er). As it is good to
> > clean up codes, I'm not sure to remove this function is a good thing.
>
> That's why I suggest removing it in 6, and deprecating it from now on.
> As 6 "will break everything anyway".
I go it but there is no easy to deprecate an internal function. Except
to spare two #define php_(u)_dirname in HEAD, I still see no gain :)
--
Pierre
http://blog.thepimp.net | http://www.libgd.org