Re: Deprecating php_dirname() in 5_3, removing in HEAD

From:	Gwynne Raskind	Date:	Thu, 06 Mar 2008 02:56:52 +0000
Subject:	Re: Deprecating php_dirname() in 5_3, removing in HEAD
References:	1 2 3 4 5 6 7	Groups:	php.internals
Request:	Send a blank email to internals+get-35993@lists.php.net to get a copy of this message

On Mar 5, 2008, at 9:52 PM, David Coallier wrote:

I'm talking about extension developers. We will all have to add yet another #ifdef for this function, in the implementation or to define php_dirname to keep the implementation clean(er). As it is good to clean up codes, I'm not sure to remove this function is a good thing.
That's why I suggest removing it in 6, and deprecating it from now on. As 6 "will break everything anyway".
I go it but there is no easy to deprecate an internal function. Except to spare two #define php_(u)_dirname in HEAD, I still see no gain :)
Perhaps it's time to make a "compatibility" extension with all those ifdefs everywhere and engine hooks.

I'll +1 that. I'll even volunteer to maintain it, if someone who knows the engine better can give me a framework to start from. -- Gwynne, Daughter of the Code "This whole world is an asylum for the incurable."