Re: Deprecating php_dirname() in 5_3, removing in HEAD

On Wed, 5 Mar 2008, David Coallier wrote: > > > > I'm talking about extension developers. We will all have to add yet > > > > another #ifdef for this function, in the implementation or to define > > > > php_dirname to keep the implementation clean(er). As it is good to > > > > clean up codes, I'm not sure to remove this function is a good thing. > > > > > > That's why I suggest removing it in 6, and deprecating it from now on. > > > As 6 "will break everything anyway". > > > > I go it but there is no easy to deprecate an internal function. Except > > to spare two #define php_(u)_dirname in HEAD, I still see no gain :) > > Perhaps it's time to make a "compatibility" extension with all those > ifdefs everywhere and engine hooks. That's fine, as long as nothing breaks. I'm with Pierre on this one. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org