Re: Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)
| From: | Etienne Kneuss | Date: | Tue, 18 Mar 2008 23:04:11 +0000 |
| Subject: | Re: Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning) | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36202@lists.php.net to get a copy of this message | ||
Hello,
the forward_static_call looks like a decent non-intrusive solution,
and your patch looks
good from what I can tell! I guess you should commit it so it can be
documented and all.
regards
On Tue, Mar 18, 2008 at 7:55 PM, Mike Lively <m@digitalsandwich.com> wrote:
> On Thu, Mar 13, 2008 at 6:48 AM, Mike Lively <m@digitalsandwich.com> wrote:
>
> >
> > New patches can be found at
> > http://www.digitalsandwich.com/Patches/index.html
> >
> > I have fixed the forward_static_call (I am not attached to the name and am
> > open to suggestions) patch to use a callable. In doing this I also added an
> > additional check to make sure the called_class is only forwarded if the
> > class whose method being called is an ancestor of the current class. If that
> > is not the case, then the behaviour will actually be identical to
> > call_user_func*.
> >
> > I created against patch for both 5_3 and 6.
> >
> > I have also updated and attached that parent:: forwarding patch for both
> > 5_3 and 6. In the event that someone wants to look at that (PLEASE??? ;)).
> >
> > - Mike Lively
> >
>
> Has anyone had a chance to look at this? I don't want to forget about it
> again or before I know it 5.3 RCs will be out and I will have missed the
> boat...again...
>
--
Etienne Kneuss
http://www.colder.ch
Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal