Re: REMINDER - stream wrappers in include_path
| From: | Dmitry Stogov | Date: | Tue, 25 Mar 2008 09:20:47 +0000 |
| Subject: | Re: REMINDER - stream wrappers in include_path | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36476@lists.php.net to get a copy of this message | ||
I hope it's the last iteration, but check me anyway.
The patch is based on latest Gregory's patch.
- optimized out strncpy() calls
- zend_resolve_path() replaced with php_resolve_path()
- improved php_resolve_path() to resolve "file://..."
- fixed possible double-free issue in _php_stream_open_wrapper_ex()
Thanks. Dmitry.
Greg Beaver wrote:
> Andi Gutmans wrote:
>> Can we please use strlcpy() instead of strncpy()? This is a coding
>> standard we implemented years ago.
>
> obviously an easy change. FYI - this also needs to be fixed in
> fopen_with_path_rel in PHP_5_2, as I copied most of the code from that
> function.
>
> Greg