Re: REMINDER - stream wrappers in include_path
| From: | Dmitry Stogov | Date: | Mon, 31 Mar 2008 06:36:06 +0000 |
| Subject: | Re: REMINDER - stream wrappers in include_path | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36699@lists.php.net to get a copy of this message | ||
Hi Greg,
I just don't see if my changes broke something.
So could you please prove that committed patch has an issue (with test case), and restore part of your patch that was going to fix the issue.
Sorry for double work.
Thanks. Dmitry.
Greg Beaver wrote:
Dmitry Stogov wrote:Hi Marcus, Sorry, if I broke something in latest patch, I just didn't see any comments from others about it. And from my point of view the patch did unnecessary things. I still think the same, becaus I mainly changed code that checks for wrapper in given argument, but not in include_path. BTW: I might miss something. Greg, could you please make a patch that fix the problem that Marcus describes (don't forget a test case).Can you elaborate on the problem you want me to fix? I thought Marcus was saying that changes made to my last patch in the ultimate commit were the problem? Thanks, Greg