Re: [PATCH] Closures and reflection improvements
| From: | Marcus Boerger | Date: | Fri, 25 Jul 2008 18:56:42 +0000 |
| Subject: | Re: [PATCH] Closures and reflection improvements | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39333@lists.php.net to get a copy of this message | ||
Hello Christian,
patch looks fine and should go in.
do you think ReflectionMethod::__construct implementation could be done
using parameterparsing 'f' rather than the spcial case 'o'? Unfortunately
we would still need the zs version unless we add another 'F' parameter
parsing that allows this two parameter case as well.
marcus
Friday, July 25, 2008, 5:41:49 PM, you wrote:
> Hi,
>>
>> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch
>>
>>
>>
>> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch
>>
> The last CVS commit for apply_func_t and TSRMLS_CC conflicted with the
> patches, I merged the conflicting line manually and reuploaded the
> patches to the same location.
> Regards,
> Christian
Best regards,
Marcus