Re: [PATCH] Closures and reflection improvements
| From: | Johannes Schlüter | Date: | Mon, 04 Aug 2008 10:59:13 +0000 |
| Subject: | Re: [PATCH] Closures and reflection improvements | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39623@lists.php.net to get a copy of this message | ||
Christian,
On Mon, 2008-08-04 at 11:33 +0400, Dmitry Stogov wrote:
> >>
> >> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch
> >>
> >>
> >>
> >> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch
> >>
> >
without applying and testing the patch:
- zend_hash_apply_with_arguments(&ce->function_table TSRMLS_CC, (apply_func_args_t)
_addmethod, 3, &ce, return_value, filter);
+ zend_hash_apply_with_arguments(&ce->function_table TSRMLS_CC, (apply_func_args_t)
_addmethod, 3, &ce, return_value, filter, intern->obj);
that looks a bit strange, probably you want 4 instead of 3 now?
johannes