Re: [PATCH] Closures and reflection improvements

From:	Christian Seiler	Date:	Fri, 25 Jul 2008 19:01:13 +0000
Subject:	Re: [PATCH] Closures and reflection improvements
References:	1 2 3	Groups:	php.internals
Request:	Send a blank email to internals+get-39334@lists.php.net to get a copy of this message

Hi Marcus,

patch looks fine and should go in.

Thanks.

do you think ReflectionMethod::__construct implementation could be done using parameterparsing 'f' rather than the spcial case 'o'?

The Problem with 'f' is that it will accept every callback, even normal functions, so that would kind of break the idea of having ReflectionMethod different than ReflectionFunction. So in my eyes, using 'o' for now is the sanest approach. Regards, Christian