Re: phar in win32 snapshots
| From: | Pierre Joye | Date: | Sat, 30 Aug 2008 18:02:02 +0000 |
| Subject: | Re: phar in win32 snapshots | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-40167@lists.php.net to get a copy of this message | ||
On Sat, Aug 30, 2008 at 7:56 PM, Greg Beaver <greg@chiaraquartet.net> wrote:
> Right, my point is that this:
>
> configure --enable-debug-pack
>
> builds phar in statically, just as zlib is built statically. Perhaps
> the --enable-snapshot-build could be fixed to match this behavior?
That's my point yes. The change has been introduced with the extension
dependency patch from Steph. I don't have the time to dig in now and
I'm not willing to change this part before alpha2 but there is an easy
fix (see below).
> It
> makes it hard to design config.w32 for multiple branches if it behaves
> differently with different unrelated config options.
You can simply change the EXTENSION call to:
EXTENSION("phar", "dirstream.c func_interceptors.c phar.c
phar_object.c phar_path_check.c stream.c tar.c util.c zip.c", false);
and the problem will be gone. The false set the "shared" argument to
false (problem is that PHP_XYZ_SHARED is set to NULL now or smtg
similar). I will have time after alpha2 to dig into this problem and
apply a fix.
> Thanks,
> Greg
>
> P.S. I'm not trying to start a war over anybody's code religion, just
> asking for an obvious bug in the build process to be corrected.
Yes, I should have not replied to other mails in this thread as they
are completely irrelevant to the actual problem (or solution).
noise--;
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org