Re: phar in win32 snapshots

Pierre Joye wrote: > On Sat, Aug 30, 2008 at 7:56 PM, Greg Beaver <greg@chiaraquartet.net> wrote: > > >> Right, my point is that this: >> >> configure --enable-debug-pack >> >> builds phar in statically, just as zlib is built statically. Perhaps >> the --enable-snapshot-build could be fixed to match this behavior? >> > > That's my point yes. The change has been introduced with the extension > dependency patch from Steph. I don't have the time to dig in now and > I'm not willing to change this part before alpha2 but there is an easy > fix (see below). > > >> It >> makes it hard to design config.w32 for multiple branches if it behaves >> differently with different unrelated config options. >> > > You can simply change the EXTENSION call to: > > EXTENSION("phar", "dirstream.c func_interceptors.c phar.c > phar_object.c phar_path_check.c stream.c tar.c util.c zip.c", false); > > and the problem will be gone. The false set the "shared" argument to > false (problem is that PHP_XYZ_SHARED is set to NULL now or smtg > similar). I will have time after alpha2 to dig into this problem and > apply a fix. OK, Johannes/Lukas, any objection to me changing the phar config.w32 for alpha2, and reverting when the core issue in the build is fixed? This is a pretty minor issue that only affects people making release builds. Greg