Re: Re: cvs: ZendEngine2 / zend_builtin_functions.c /tests 009.phpt php-src/ext/reflection/tests 027.phpt php-src/ext/standard/tests/class_object
get_class_error_001.phpt get_class_variation_001.phpt
| From: | Pierre Joye | Date: | Mon, 16 Mar 2009 15:49:44 +0000 |
| Subject: | Re: Re: cvs: ZendEngine2 / zend_builtin_functions.c /tests 009.phpt php-src/ext/reflection/tests 027.phpt php-src/ext/standard/tests/class_object get_class_error_001.phpt get_class_variation_001.phpt |
||
| References: | 1 2 | Groups: | php.internals php.zend-engine.cvs |
| Request: | Send a blank email to internals+get-43364@lists.php.net to get a copy of this message | ||
2009/3/16 Johannes Schlüter <johannes@php.net>:
> Hi,
>
> On Mon, 2009-03-16 at 09:52 +0000, "Dmitry Stogov" wrote:
>> Log:
>> Fixed bug #47664 (get_class returns NULL instead of FALSE)
> [...]
>> @@ -716,7 +716,7 @@
>> int dup;
>>
>> if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|o",
>> &obj) == FAILURE) {
>> - return;
>> + RETURN_FALSE;
>> }
>
> Usually we return NULL in case parameter parsing fails, this is
> documented like this:
Hi Johannes,
Please read the bug report. In this case I think that we should not
break it only to follow this (arguable :) rule. See the documentation
of get_class as well: http://de.php.net/get_class
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org