Re: Re: cvs: ZendEngine2 / zend_builtin_functions.c /tests 009.phpt php-src/ext/reflection/tests 027.phpt php-src/ext/standard/tests/class_object
get_class_error_001.phpt get_class_variation_001.phpt
| From: | Pierre Joye | Date: | Mon, 16 Mar 2009 17:45:25 +0000 |
| Subject: | Re: Re: cvs: ZendEngine2 / zend_builtin_functions.c /tests 009.phpt php-src/ext/reflection/tests 027.phpt php-src/ext/standard/tests/class_object get_class_error_001.phpt get_class_variation_001.phpt |
||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-43368@lists.php.net to get a copy of this message | ||
On Mon, Mar 16, 2009 at 6:43 PM, Stanislav Malyshev <stas@zend.com> wrote:
> Hi!
>
>>> If all other functions return NULL with wrong args, why should get_class
>>> return false? Is there any value in it besides the fact that docs say so?
>>
>> The main reason is the documentation. It introduces a useless BC break
>> which was reported in #47664.
>
> Well, sometimes a bug is a bug and we can't keep BC just for bugs, unless it
> is useful for something.
The new parsing API and the strictness of this "return NULL" rule is
new and arguable. As it is not that important (work 'round is easy), I
tend to prefer to minimize the wtf instead of being too strict.
--
Pierre
http://blog.thepimp.net | http://www.libgd.org