Re: Re: cvs: ZendEngine2 / zend_builtin_functions.c /tests 009.phpt php-src/ext/reflection/tests 027.phpt php-src/ext/standard/tests/class_object
get_class_error_001.phpt get_class_variation_001.phpt
| From: | Pierre Joye | Date: | Mon, 16 Mar 2009 17:41:53 +0000 |
| Subject: | Re: Re: cvs: ZendEngine2 / zend_builtin_functions.c /tests 009.phpt php-src/ext/reflection/tests 027.phpt php-src/ext/standard/tests/class_object get_class_error_001.phpt get_class_variation_001.phpt |
||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-43366@lists.php.net to get a copy of this message | ||
2009/3/16 Stanislav Malyshev <stas@zend.com>:
> Hi!
>
>>> Log:
>>> Fixed bug #47664 (get_class returns NULL instead of FALSE)
>>
>> [...]
>>>
>>> @@ -716,7 +716,7 @@
>>> int dup;
>>> if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|o",
>>> &obj) == FAILURE) {
>>> - return;
>>> + RETURN_FALSE;
>>> }
>>
>> Usually we return NULL in case parameter parsing fails, this is
>> documented like this:
>
> If all other functions return NULL with wrong args, why should get_class
> return false? Is there any value in it besides the fact that docs say so?
The main reason is the documentation. It introduces a useless BC break
which was reported in #47664.
--
Pierre
http://blog.thepimp.net | http://www.libgd.org