Re: [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool
| From: | Jani Taskinen | Date: | Tue, 15 Dec 2009 09:04:56 +0000 |
| Subject: | Re: [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-46417@lists.php.net to get a copy of this message | ||
On 12/14/2009 10:16 PM, Jérôme Loyet wrote:
Hi tony, There is several things in this patch: 1- makes log message about pool concistent. I set it to "[pool %s] message". Before there where different variants: pool %s, foo (pool %s) bar [pool %s] [%s] 2- corrects some log messages which were not very meaningful for end users 3- Some log level have been switched from NOTICE to DEBUG, so that the log_file in normal operation would not be a nightmare to read (with a lot of anoying and useless messages for end users)Wouldn't it make more sense to make this configurable? And thus allow people to log how they prefer.. --Jani