Re: [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool
| From: | Tjerk Anne Meesters | Date: | Tue, 15 Dec 2009 12:19:45 +0000 |
| Subject: | Re: [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-46422@lists.php.net to get a copy of this message | ||
The only two things that would come up after reading Jani's email is:
1) Make the log string configurable, such as CustomLog in apache
2) Configure the log level threshold, though I think that should
already be there in the first place.
On 12/15/09, Antony Dovgal <tony@daylessday.org> wrote:
> On 15.12.2009 12:30, Jani Taskinen wrote:
>>> Surely log_level is configurable.
>>> Jerome just changed error level of some error messages to reduce the
>>> amount of notices in the log.
>>
>> I replied badly, I meant ALL the points in the mail. Configurable log
>> entries, levels, etc. Not some static fprintf() stuff. :)
>
> Well, now you've lost me completely.
>
>> 1- makes log message about pool concistent. I set it to "[pool %s]
>> message". Before there where different variants:
>> pool %s,
>> foo (pool %s) bar
>> [pool %s]
>> [%s]
>>
>> 2- corrects some log messages which were not very meaningful for end users
>
> Configurable error messages, huh?
>
>> 3- Some log level have been switched from NOTICE to DEBUG, so that the
>> log_file in normal operation would not be a nightmare to read (with a
>> lot of anoying and useless messages for end users)
>
> Configurable error level for certain error messages?
>
> --
> Wbr,
> Antony Dovgal
> ---
> http://pinba.org - realtime statistics for PHP
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
--
--
Tjerk