Re: [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009/12/15 Tjerk Anne Meesters <datibbaw@php.net>: > The only two things that would come up after reading Jani's email is: so am I > 1) Make the log string configurable, such as CustomLog in apache Yes but CustomLog is for access log, this feature is not present in php-fpm (should it be ?) All the log message (my patch is changing) are error, debug or warning message like: - WARNING: unable to open log file - php-fpm started well - unable to fork ... There is no way to make this configurable ... because it's totally useless > 2) Configure the log level threshold, though I think that should > already be there in the first place. Yes it's already in place > > On 12/15/09, Antony Dovgal <tony@daylessday.org> wrote: >> On 15.12.2009 12:30, Jani Taskinen wrote: >>>> Surely log_level is configurable. >>>> Jerome just changed error level of some error messages to reduce the >>>> amount of notices in the log. >>> >>> I replied badly, I meant ALL the points in the mail. Configurable log >>> entries, levels, etc. Not some static fprintf() stuff. :) >> >> Well, now you've lost me completely. >> >>> 1- makes log message about pool concistent. I set it to "[pool %s] >>> message". Before there where different variants: >>> pool %s, >>> foo (pool %s) bar >>> [pool %s] >>> [%s] >>> >>> 2- corrects some log messages which were not very meaningful for end users >> >> Configurable error messages, huh? >> >>> 3- Some log level have been switched from NOTICE to DEBUG, so that the >>> log_file in normal operation would not be a nightmare to read (with a >>> lot of anoying and useless messages for end users) >> >> Configurable error level for certain error messages? >> >> -- >> Wbr, >> Antony Dovgal >> --- >> http://pinba.org - realtime statistics for PHP >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > -- > -- > Tjerk >