why not use strtol instead of php_filter_parse_{int,hex,octal}?
| From: | Raphael Geissert | Date: | Sun, 21 Feb 2010 17:27:14 +0000 |
| Subject: | why not use strtol instead of php_filter_parse_{int,hex,octal}? | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-47013@lists.php.net to get a copy of this message | ||
Hi,
While working on bug #51023, Sean and I were wondering why they were written
in the first place, instead of using strtol; which can handle the three
cases and properly detect overflows and underflows (and doesn't risk being
optimised-away like with the current implementations).
If there's no objection, I would like to remove them entirely and use strtol
in php_filter_int.
Cheers,
--
Raphael Geissert